Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataXD duplication #2144

Closed
lucas-wilkins opened this issue Aug 15, 2022 · 3 comments
Closed

DataXD duplication #2144

lucas-wilkins opened this issue Aug 15, 2022 · 3 comments
Labels
Discuss At The Call Issues to be discussed at the fortnightly call Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Infrastructure GitHub, project structure, community etc

Comments

@lucas-wilkins
Copy link
Contributor

There is a Data1D definition in both sasview (in Plotting for some reason) and sasmodels.data, are these expected to become a single type during the sasdata extraction? They probably should.
@lucas-wilkins lucas-wilkins added Infrastructure GitHub, project structure, community etc Discuss At The Call Issues to be discussed at the fortnightly call Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general labels Aug 15, 2022
@lucas-wilkins
Copy link
Contributor Author

Also, there is sas.sascalc.dataloader.data_info.Data1D which is yet another definition of Data1D that is actually a different class!

@lucas-wilkins
Copy link
Contributor Author

@krzywon Thoughts?

@lucas-wilkins
Copy link
Contributor Author

I think the discussion today answered my questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discuss At The Call Issues to be discussed at the fortnightly call Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general Infrastructure GitHub, project structure, community etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucas-wilkins