Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean __init__.py #2185

Closed
lucas-wilkins opened this issue Sep 12, 2022 · 4 comments
Closed

Clean __init__.py #2185

lucas-wilkins opened this issue Sep 12, 2022 · 4 comments
Assignees
@lucas-wilkins
Labels
Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general

Comments

@lucas-wilkins
Copy link
Contributor

There seems to be a few unused methods in sas/init.py. Some I have already removed for #2164, but there are still some mentioning app_dir. These should probably be removed? @wpotrzebowski @krzywon @rozyczko @butlerpd
@lucas-wilkins lucas-wilkins added the Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general label Sep 12, 2022
@lucas-wilkins lucas-wilkins self-assigned this Sep 14, 2022
@lucas-wilkins
Copy link
Contributor Author

Should be closed by #2164

@butlerpd
Copy link
Member

Sorry @lucas-wilkins for slow response. Though I actually have no insights on this one I'm afraid so no help anyway ☹️

@lucas-wilkins
Copy link
Contributor Author

@butlerpd no worries, I have ended up deleting nearly all of it in in #2168

@lucas-wilkins
Copy link
Contributor Author

Basically as done as it will be any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-wilkins lucas-wilkins

Labels
Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucas-wilkins @butlerpd