-
Notifications
You must be signed in to change notification settings - Fork 41
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI is double-running on PRs #2307
Comments
Running the unit tests only on push would potentially mean that the merged version doesn't ever get tested. Except in the situation where the merge will be a fast-forward, they are running adding different code. For work in progress branches, potentially all three sets of tests need to be run. For merges, all three also need to be run. I'm not sure how to reduce the runs, or if it's even worth doing. |
Back to the ticket:
Looking at the docs we should should ignore most The merge action isn't even listed in the We shouldn't need to run tests on the The git fork vs. branch workflow doesn't seem relevant to the issue. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Describe the bug
All CI tests, installers, and doc builds are running twice on commits to branches once a PR is created. Simple origin, most of our GH actions scripts use a trigger of
[push,pull_request]
I propose that we run tests on
[push]
, installers on[pull_request]
and docs probably also on[push]
.To Reproduce
PR commits have 24 run tests instead of the proper 10.
Expected behavior
Tests should not be duplicated.
The text was updated successfully, but these errors were encountered: