Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is double-running on PRs #2307

Closed
pbeaucage opened this issue Oct 28, 2022 · 2 comments
Closed

CI is double-running on PRs #2307

pbeaucage opened this issue Oct 28, 2022 · 2 comments

Comments

@pbeaucage
Copy link
Contributor

Describe the bug
All CI tests, installers, and doc builds are running twice on commits to branches once a PR is created. Simple origin, most of our GH actions scripts use a trigger of [push,pull_request]

I propose that we run tests on [push], installers on [pull_request] and docs probably also on [push].

To Reproduce
PR commits have 24 run tests instead of the proper 10.

Expected behavior
Tests should not be duplicated.

@llimeht
Copy link
Contributor

llimeht commented Oct 28, 2022

Running the unit tests only on push would potentially mean that the merged version doesn't ever get tested. Except in the situation where the merge will be a fast-forward, they are running adding different code.

For work in progress branches, potentially all three sets of tests need to be run. For merges, all three also need to be run. I'm not sure how to reduce the runs, or if it's even worth doing.

@pkienzle
Copy link
Contributor

pkienzle commented Nov 4, 2022

Back to the ticket:

Tests are running on both push and pull_request. Propose running them only on push. Concern is that push doesn't catch merge requests.

Looking at the docs we should should ignore most pull_request triggers. Just adding a comment to the discussion should not cause a rebuild.

The merge action isn't even listed in the pull_request activity types, so does it even solve the merge problem?

We shouldn't need to run tests on the pull_request open activity since it should have been built and tested on the push. However, I wouldn't be surprised if it didn't show the last build activity before the PR, so this might be the most expedient way of having the test results appear.

The git fork vs. branch workflow doesn't seem relevant to the issue.

@SasView SasView locked and limited conversation to collaborators Nov 4, 2022
@lucas-wilkins lucas-wilkins converted this issue into discussion #2371 Nov 4, 2022
@SasView SasView deleted a comment from butlerpd Nov 4, 2022
@SasView SasView deleted a comment from llimeht Nov 4, 2022
@SasView SasView deleted a comment from andyfaff Nov 4, 2022
@SasView SasView deleted a comment from andyfaff Nov 4, 2022
@SasView SasView deleted a comment from llimeht Nov 4, 2022
@SasView SasView deleted a comment from andyfaff Nov 4, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants