Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector slicer doesn't update properly when parameters changed #2726

Closed
jack-rooks opened this issue Jan 17, 2024 · 5 comments · Fixed by #1919
Closed

Sector slicer doesn't update properly when parameters changed #2726

jack-rooks opened this issue Jan 17, 2024 · 5 comments · Fixed by #1919
Assignees
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality

Comments

@jack-rooks
Copy link
Contributor

Describe the bug
Trying to update the number of bins used in the sector slicer for 2D data gives an error and does not function.

Traceback (most recent call last): File "C:\Users\Jack\GitRepos\sasview\src\sas\qtgui\Plotting\SlicerModel.py", line 66, in setParamsFromModelItem self.setParams(params) File "C:\Users\Jack\GitRepos\sasview\src\sas\qtgui\Plotting\Slicers\SectorSlicer.py", line 275, in setParams self.right_line.update(phi=phi, delta=None, mline=self.main_line, File "C:\Users\Jack\GitRepos\sasview\src\sas\qtgui\Plotting\Slicers\SectorSlicer.py", line 384, in update self.theta = mline.alpha + self.phi AttributeError: 'LineInteractor' object has no attribute 'alpha'

To Reproduce
Steps to reproduce the behavior:

  1. Open SasView and look at the fitting panel that is open by default
  2. Select a category and model (cylinder and cylinder was used for this)
  3. Enable "2D view" in the options section at the bottom left of the fitting panel
  4. Click "Calculate" then "Show Plot" at the bottom right of the window
  5. Right click the 2D plot that was generated and click "Edit Slicer Parameters" and select the "Sector" slicer type from the dropdown
  6. Change nbins to any value
  7. See error

Expected behavior
The number of bins used for the slicer should update

SasView version:

  • 6.0.0a1 (main branch)

Operating system:

  • OS: Windows 10 Version 10.0.19045 Build 19045
@jack-rooks jack-rooks added Defect Bug or undesirable behaviour Slicers Concerns slicer functionality labels Jan 17, 2024
@jack-rooks
Copy link
Contributor Author

Note: new bug, not present in 5.0.5

@jack-rooks jack-rooks changed the title Sector slicer number of bins (nbins) can't be changed Sector slicer doesn't update properly when parameters changed Jan 17, 2024
@jack-rooks
Copy link
Contributor Author

Also doesn't work when phi and delta_phi are changed in the slicer parameters, but not when done in the graph by dragging the lines

@jack-rooks
Copy link
Contributor Author

May be related to #2636

@jack-rooks
Copy link
Contributor Author

Fixed by 2100_2726_2752_Slicer-bugfixes. Leaving this open for now as it has not been merged

@jack-rooks jack-rooks added the Being Tested When an issue is done but not ready to be closed. label Jan 21, 2024
@jack-rooks jack-rooks self-assigned this Jan 22, 2024
@jack-rooks jack-rooks linked a pull request Jan 30, 2024 that will close this issue
@butlerpd
Copy link
Member

butlerpd commented Jul 5, 2024

All has now been merged so closing this ticket

@butlerpd butlerpd closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Being Tested When an issue is done but not ready to be closed. Defect Bug or undesirable behaviour Slicers Concerns slicer functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants