Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move old slicer detection to GuiUtils #2838

Open
jack-rooks opened this issue Mar 28, 2024 · 0 comments
Open

Move old slicer detection to GuiUtils #2838

jack-rooks opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
Enhancement Feature requests and/or general improvements Plotting Concerns plotting functionality Slicers Concerns slicer functionality

Comments

@jack-rooks
Copy link
Contributor

To address some issues with old slicer plots reappearing (#2752) some extra checks were included. Most of this is in qtgui > Plotting > Plotter2D under setSlicer, but one of the attributes used for this is included in each slicer. It was brought up in review (pull request 1919) that this should probably be moved to GuiUtils (where much of this code was written based off of).

This won't be done in time for the merge, but at a later date we should generalize this code and move it to GuiUtils so that it can be used for other plotters if needed (or rewrite this to use the existing GuiUtils functionality).

@jack-rooks jack-rooks added Enhancement Feature requests and/or general improvements Slicers Concerns slicer functionality Plotting Concerns plotting functionality labels Mar 28, 2024
@jack-rooks jack-rooks self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Plotting Concerns plotting functionality Slicers Concerns slicer functionality
Projects
None yet
Development

No branches or pull requests

1 participant