Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why Image Viewer tool is not loading .TIF or .BMP (Trac #265) #413

Closed
smk78 opened this issue Mar 30, 2019 · 12 comments
Closed
Labels
Critical High priority Defect Bug or undesirable behaviour
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Paul said on 31 May:

It seems that jpg, png, and gif work but that bmp and tiff currently
do not.

Migrated from http://trac.sasview.org/ticket/265

{
    "status": "closed",
    "changetime": "2015-02-18T17:31:14",
    "_ts": "2015-02-18 17:31:14.794689+00:00",
    "description": "Paul said on 31 May:\n\nIt seems that jpg, png, and gif work but that bmp and tiff currently \ndo not.  ",
    "reporter": "smk78",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2014-05-31T12:50:20",
    "component": "SasView",
    "summary": "Investigate why Image Viewer tool is not loading .TIF or .BMP",
    "priority": "critical",
    "keywords": ".TIF, .BMP, File Extension",
    "milestone": "SasView 3.1.0",
    "owner": "",
    "type": "defect"
}
@smk78 smk78 added this to the SasView 3.1.0 milestone Mar 30, 2019
@smk78 smk78 added Critical High priority Defect Bug or undesirable behaviour Incomplete Migration and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2014/05/31 15:33:31: butler commented:

On further investigation, this works on my development system (windows 8.1 laptop with packages as given in ticket #361 [raw-attachment:sasview-dependencies-survey.pdf:ticket:213 Table]. It does not work however in the exe bundle.

imageviewer.py in the guiframe package seems to be doing the work and is using matplotlib.image.imread to load the files. My matplotlib is 1.3 instead of the 1.1. on the build system. However this code was introduced by Jae Hie about a year ago (probably using 0.98?) so not likly to be cuplrit? Looking for dependencies that might be a problem I found an article which suggests that only PNG is natively supported by matplotlib and that the other formats rely on PIL -- but my system (which works) does not have PIL while the build system (which seems not to work) does have PIL.

@butlerpd
Copy link
Member

Trac update at 2014/05/31 15:33:45: butler changed milestone from "SasView Next Release +1" to "SasView 3.0.1"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2015/01/14 12:37:22: ajj changed workpackage from "" to "SasView Bug Fixing"

@sasview-bot
Copy link

Trac update at 2015/02/18 11:51:54:

  • krzywon changed attachment from "" to "test_bmp.bmp"
  • krzywon commented:

Test BMP file

@sasview-bot
Copy link

Trac update at 2015/02/18 11:52:06:

  • krzywon changed attachment from "" to "test_gif.gif"
  • krzywon commented:

Test GIF file

@sasview-bot
Copy link

Trac update at 2015/02/18 11:52:18:

  • krzywon changed attachment from "" to "test_jpg.jpg"
  • krzywon commented:

Test JPG File

@sasview-bot
Copy link

Trac update at 2015/02/18 11:52:32:

  • krzywon changed attachment from "" to "test_png.png"
  • krzywon commented:

Test PNG File

@sasview-bot
Copy link

Trac update at 2015/02/18 11:52:52:

  • krzywon changed attachment from "" to "test_tiff.tif"
  • krzywon commented:

Test Tiff Full Color File

@sasview-bot
Copy link

Trac update at 2015/02/18 11:53:10:

  • krzywon changed attachment from "" to "test_tiff_bw.tif"
  • krzywon commented:

Test Tiff Black And White File

@sasview-bot
Copy link

Trac update at 2015/02/18 12:00:05: krzywon commented:

I can load and manipulate all of the image files attached to this ticket using the most recent trunk version of SasView. The images are all the same 2D data set converted into various image types. Are there any images that still are not working?

@mdoucet
Copy link
Contributor

mdoucet commented Mar 30, 2019

Trac update at 2015/02/18 16:51:38: mathieu commented:

The images load on my Mac. The only problem I have is that the wildcards used in the dialog won't let you select any file. All files on the Mac file dialog are grayed out and there's no way to change the file extension filter. Apparently the support for wildcards isn't great with wx (at least according to their docs). I'll change it to load any file, but with better error catching (there is none at the moment).

@mdoucet
Copy link
Contributor

mdoucet commented Mar 30, 2019

Trac update at 2015/02/18 17:31:14:

  • mathieu changed resolution from "" to "fixed"
  • mathieu changed status from "new" to "closed"

@smk78 smk78 closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical High priority Defect Bug or undesirable behaviour
Projects
None yet
Development

No branches or pull requests

5 participants