Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving plot to file doesn't work from context menu (Trac #442) #576

Closed
butlerpd opened this issue Mar 30, 2019 · 2 comments
Closed

Saving plot to file doesn't work from context menu (Trac #442) #576

butlerpd opened this issue Mar 30, 2019 · 2 comments
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

As reported by Steve King during v. 3.1.0 release testing the toolbar save icon works correctly but the context menu save does not.

Migrated from http://trac.sasview.org/ticket/442

{
    "status": "closed",
    "changetime": "2015-07-04T15:43:06",
    "_ts": "2015-07-04 15:43:06.415626+00:00",
    "description": "As reported by Steve King during v. 3.1.0 release testing the toolbar save icon works correctly but the context menu save does not.",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2015-07-03T22:18:17",
    "component": "SasView",
    "summary": "Saving plot to file doesn't work from context menu",
    "priority": "major",
    "keywords": "plot, matplotlib",
    "milestone": "SasView 3.1.0",
    "owner": "butler",
    "type": "defect"
}
@butlerpd butlerpd added this to the SasView 3.1.0 milestone Mar 30, 2019
@butlerpd butlerpd self-assigned this Mar 30, 2019
@butlerpd butlerpd added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member Author

Trac update at 2015/07/03 22:30:48: butler commented:

Matplot lib got us again!!! saving is no longer toolbar.save but toolbar.save_figure. I have fixed locally. will push one I finish fixing the printing issue (or later tonight whichever comes first).

@butlerpd
Copy link
Member Author

Trac update at 2015/07/04 15:43:06:

  • butler commented:

Have fixed as per above. the toolbar worked because save is a part of the default toolbar provided by Matplotlib and hence handled directly by it. The pop up menu had to make the call directly and was now wrong.

Fix works on both mac and PC from instalable.
Something that may need more testing (and a possible ticket) is that it seems many formats are possible to save to (looks like coming from host environment?). Tried a couple which worked but then jpeg save poped up an error on mac that it was not supported. (jpeg worked on pc). As I say - needs more testing and if appropriate a new ticket.

  • butler changed resolution from "" to "fixed"
  • butler changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

1 participant