Convert model editors to support sasmodels (Trac #504)

[butlerpd]

Need to edit model_editor.py in sasview>src>sas>perspectives>calculator to accommodate new model structure. Mainly the composite model editor and the Easy model editor.

Read notes added in the file about suggested structural changes that might be appropriate at this time as well.

Migrated from http://trac.sasview.org/ticket/504

{
    "status": "closed",
    "changetime": "2016-06-19T16:01:36",
    "_ts": "2016-06-19 16:01:36.524788+00:00",
    "description": "Need to edit model_editor.py in sasview>src>sas>perspectives>calculator to accommodate new model structure.  Mainly the composite model editor and the Easy model editor. \n\nRead notes added in the file about suggested structural changes that might be appropriate at this time as well. ",
    "reporter": "butler",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasModels Redesign",
    "time": "2016-03-06T22:23:40",
    "component": "SasView",
    "summary": "Convert model editors to support sasmodels",
    "priority": "blocker",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "gonzalezm",
    "type": "task"
}

[rozyczko]

Trac update at 2016/03/10 10:41:51: piotr commented:

Remember about other requirements, like http://trac.sasview.org/ticket/366

[butlerpd]

Trac update at 2016/03/12 23:40:36: butler commented:

#501 regards allowing reparametrization of a model. It is interesting that the author of the ticket suggests an implementation similar to a custom model, as I've thought of this as a models infrastructure work. As an editor is not as intellectually satisfying and perhaps not as flexible a solution, but probably much more doable in the short term. Even so, as I understand it, this would have to be a 4th editor not an upgrade to an existing editor? (current model_editor.py has 3 classes as I recall, one is a window to pyshell, one is the sum models panel, and one is the custom model panel). One question however is what to do about c models. updating the python file output to be a sasmodel should be "easy" (meaning plenty of work but the tasks are clear). It might be nice to allow for adding the C bits?? but suspect that is a bridge too far for this release?

Replying to [comment:1 piotr]:

Remember about other requirements, like http://trac.sasview.org/ticket/366

[ajj]

Trac update at 2016/03/18 16:07:15: ajj commented:

Partially done. Easy sum/multi works.

Custom model editor does not yet.

[butlerpd]

Trac update at 2016/03/19 12:02:03:

• butler changed owner from "" to "gonzalezm"
• butler changed status from "new" to "assigned"

[butlerpd]

Trac update at 2016/03/21 19:00:32: butler changed _comment0 from "The custom model editor works and now creates a "sasmodel-type" python file that SasView can load and use. However the previous test to check that the model compiles and runs have not yet be reimplemented." to "1466351294194564"

[gonzalezma]

Trac update at 2016/03/21 19:00:32: gonzalezm commented:

The custom model editor works and now creates a "sasmodel-type" python file that !SasView can load and use. However the previous test to check that the model compiles and runs have not yet be reimplemented.

[butlerpd]

Trac update at 2016/06/19 16:01:36:

• butler commented:

This was also done some time ago. However the sum model has been broken by numerous changes to sasmodels re-structuring but that is the subject of ticket #715.

Am thus closing this ticket now.

• butler changed resolution from "" to "fixed"
• butler changed status from "assigned" to "closed"