Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SasView Category code (Trac #526) #659

Closed
butlerpd opened this issue Mar 30, 2019 · 5 comments
Closed

Refactor SasView Category code (Trac #526) #659

butlerpd opened this issue Mar 30, 2019 · 5 comments
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Milestone

Comments

@butlerpd
Copy link
Member

butlerpd commented Mar 30, 2019

Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it. Mainly:

1 Remove default.json from the repo
2 Change the code to create a serialized.json from model information instead of looking for default.json
3 If model is not in serialized.json, first look in model information for default categories. If none then, and only then, add to uncategorized.

Migrated from http://trac.sasview.org/ticket/526

{
    "status": "new",
    "changetime": "2019-03-02T01:14:49",
    "_ts": "2019-03-02 01:14:49.765742+00:00",
    "description": "Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it.  Mainly:\n\n1 Remove default.json from the repo\n2 Change the code to create a serialized.json from model information instead of looking for default.json\n3 If model is not in serialized.json, first look in model information for default categories.  If none then, and only then, add to uncategorized.",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Framework Enhancements",
    "time": "2016-03-16T22:53:35",
    "component": "SasView",
    "summary": "Refactor SasView Category code",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "",
    "type": "enhancement"
}
@butlerpd butlerpd added this to the SasView 5.0.0 milestone Mar 30, 2019
@butlerpd butlerpd added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member Author

Trac update at 2016/03/16 22:54:04: butler changed description from:

Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it. Mainly:

  1. Remove default.json from the repo
  2. Change the code to create a serialized.json from model information instead of looking for default.json
  3. If model is not in serialized.json, first look in model information for default categories. If none then, and only then, add to uncategorized.

to:

Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it. Mainly:

1- Remove default.json from the repo
2- Change the code to create a serialized.json from model information instead of looking for default.json
3- If model is not in serialized.json, first look in model information for default categories. If none then, and only then, add to uncategorized.

@butlerpd
Copy link
Member Author

Trac update at 2016/03/16 22:54:44: butler changed description from:

Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it. Mainly:

1- Remove default.json from the repo
2- Change the code to create a serialized.json from model information instead of looking for default.json
3- If model is not in serialized.json, first look in model information for default categories. If none then, and only then, add to uncategorized.

to:

Once we move to adding default categories to the python model we will need to change the !SasView category code to take advantage of it. Mainly:

1 Remove default.json from the repo
2 Change the code to create a serialized.json from model information instead of looking for default.json
3 If model is not in serialized.json, first look in model information for default categories. If none then, and only then, add to uncategorized.

@butlerpd
Copy link
Member Author

Trac update at 2017/10/26 11:37:58:

  • butler commented:

This may be mostly moot at this point but probably wait for 5.0 to close?

  • butler changed milestone from "SasView Next Release +1" to "SasView 5.0.0"
  • butler changed summary from "Refactor !SasView Category code" to "Refactor SasView Category code"

@butlerpd
Copy link
Member Author

Trac update at 2019/03/02 01:14:49: butler changed workpackage from "SasModels Redesign" to "SasView Framework Enhancements"

@pkienzle
Copy link
Contributor

pkienzle commented Aug 9, 2023

The refactor is complete so closing the ticket. Opening a new ticket to report current errors.

@pkienzle pkienzle closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

4 participants