Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help when using S*P in SasView GUI (Trac #529) #1332

Open
butlerpd opened this issue Mar 30, 2019 · 6 comments
Open

Fix help when using S*P in SasView GUI (Trac #529) #1332

butlerpd opened this issue Mar 30, 2019 · 6 comments
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements Minor Small job Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable.
Milestone

Comments

@butlerpd
Copy link
Member

At Code Camp IV it was pointed out that Both the help and the description (quick pop up help) only point to one of the two models if P*S is up. The quick help goes to P and the full help goes to S. Paul K. points out we could replace HELP with question marks on each of P and S that takes the help to the respective place but that probably best if we chose to ditch the pop up help (see ticket #661).

Migrated from http://trac.sasview.org/ticket/529

{
    "status": "new",
    "changetime": "2018-09-10T13:32:26",
    "_ts": "2018-09-10 13:32:26.179503+00:00",
    "description": "At Code Camp IV it was pointed out that Both the help and the description (quick pop up help) only point to one of the two models if P*S is up.  The quick help goes to P and the full help goes to S.  Paul K. points out we could replace HELP with question marks on each of P and S that takes the help to the respective place but that probably best if we chose to ditch the pop up help (see ticket #528).",
    "reporter": "butler",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView GUI Enhancements",
    "time": "2016-03-17T14:33:27",
    "component": "SasView",
    "summary": "Fix help when using S*P in SasView GUI",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "",
    "type": "enhancement"
}
@butlerpd
Copy link
Member Author

Trac update at 2017/10/23 12:56:06: butler changed milestone from "SasView Next Release +1" to "SasView 5.0.0"

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/09 09:59:06:

  • smk78 commented:

Testing 4.2beta on W7.

Reverting this to !SasView 4.2.0 as a blocker as just discovered that if you create a mixture model with Sum|Multiply then got to Plugin Models and select the mixture model, whilst the Description tells you what models are in the mixture, the Help button redirects to a nonexistent location: http://index.html/

It should perhaps redirect to !SasView/doc/user/sasgui/perspectives/fitting/models/index.html (ie, the full list of models)?

  • smk78 changed milestone from "SasView 5.0.0" to "SasView 4.2.0"
  • smk78 changed priority from "major" to "blocker"
  • smk78 changed workpackage from "SasView Documentation" to "SasView Bug Fixing"

@butlerpd
Copy link
Member Author

Trac update at 2018/09/09 15:36:34: butler commented:

In changeset b439881:

#!CommitTicketReference repository="sasview" revision="b43988196e5c4f2dfbf3ec5c9b66703d5656b08d"
Fix blank page when clicking help on a plugin model

Addresses #662.  Plungin models do not have model.html help pages so
check if model is plugin. If so send to general model help.  If regular
built-in model send to model.html help page. eventually need better
solution .. also for original problem with ticket which is the P*S.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/10 13:28:20: smk78 commented:

Latest issue addressed by @Butler in !SasView PR177 ticket-529_PluginModelDocFix branch. Now merged.

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/10 13:30:18:

  • smk78 changed milestone from "SasView 4.2.0" to "SasView 5.0.0"
  • smk78 changed priority from "blocker" to "major"
  • smk78 changed workpackage from "SasView Bug Fixing" to "SasView GUI Enhancements"

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

Trac update at 2018/09/10 13:32:26: smk78 commented:

To note: latest issue is a workaround: better solution would be something like that outlined in the original ticket above.

Can't imagine we will fix in 4.x so moving to 5.0 as a GUI Enhancement.

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@butlerpd butlerpd transferred this issue from SasView/sasmodels May 12, 2019
@butlerpd butlerpd added Defect Bug or undesirable behaviour Minor Small job SasView Framework Enhancements labels May 12, 2019
@butlerpd butlerpd added this to the SasView 5.1.0 milestone May 12, 2019
@lucas-wilkins lucas-wilkins added Enhancement Feature requests and/or general improvements and removed SasView Framework Enhancements labels Oct 31, 2022
@krzywon krzywon added the Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable. label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Enhancement Feature requests and/or general improvements Minor Small job Stale Mark for potential close: issue no longer seems relevant / probably complete / probably not doable.
Projects
None yet
Development

No branches or pull requests

4 participants