Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pluginmodel.py once we have appropriate sasmodels replacement (Trac #549) #1835

Open
ajj opened this issue Mar 30, 2019 · 3 comments
Open
Labels
Fitting Perspective Concerns the fitting perspective Major Big change in the code or important change in behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Currently need pluginmodel.py to provide Model1DPlugin class used for simple sum/multi user generated models.

This can be removed once we have sum/product working from sasmodels.

Migrated from http://trac.sasview.org/ticket/549

{
    "status": "new",
    "changetime": "2019-03-02T00:41:20",
    "_ts": "2019-03-02 00:41:20.532424+00:00",
    "description": "Currently need pluginmodel.py to provide Model1DPlugin class used for simple sum/multi user generated models.\n\nThis can be removed once we have sum/product working from sasmodels.",
    "reporter": "ajj",
    "cc": "",
    "resolution": "",
    "workpackage": "SasModels Infrastructure",
    "time": "2016-03-21T15:24:13",
    "component": "SasView",
    "summary": "Remove pluginmodel.py once we have appropriate sasmodels replacement",
    "priority": "critical",
    "keywords": "",
    "milestone": "SasView Next Release +1",
    "owner": "",
    "type": "defect"
}
@ajj
Copy link
Member Author

ajj commented Mar 30, 2019

Trac update at 2016/08/16 13:46:50: ajj changed milestone from "SasView 4.0.0" to "SasView Next Release +1"

@butlerpd
Copy link
Member

Trac update at 2019/03/02 00:41:20:

  • butler commented:

This should have been done for 4.2 or 4.2.1 I believe? needs testing but if ready the sooner we clean the code up the better. Raising to critical.

  • butler changed priority from "major" to "critical"
  • butler changed workpackage from "SasModels Redesign" to "SasModels Infrastructure"

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@butlerpd butlerpd transferred this issue from SasView/sasmodels May 2, 2021
@butlerpd
Copy link
Member

butlerpd commented May 2, 2021

pluginmodel.py is in sascalc not sasmodels so just moved this ticket back to this repo. It is targeting 4.x but really this should be done in 5x at this point.

@butlerpd butlerpd added this to the SasView 5.1.0 milestone May 2, 2021
@butlerpd butlerpd added Major Big change in the code or important change in behaviour SasView Fitting Redesign labels May 2, 2021
@lucas-wilkins lucas-wilkins added Fitting Perspective Concerns the fitting perspective and removed SasView Fitting Redesign labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fitting Perspective Concerns the fitting perspective Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants