-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swollen sphere parameterization (Trac #605) #737
Comments
Trac update at |
Trac update at
This model was one being written by ILL summer student in Summer 2016 but was then removed due to massive issues with the commit before the release -- at some point a new version may be put in by Miguel but seems to be in limbo so closing this ticket. If and when such a model does get submitted it should be reviewed from scratch.
|
Improve description of ''phi'' and ''x'' parameters. Is ''phi'' supposed to be volume fraction of spheres, and ''x'' the solvent fraction within spheres? The redundant ''scale'' parameter is automatically included in all models, and has been removed.
Documentation, including equations, needs to reflect the additional parameters.
''phi'' need not be polydisperse; the integral over a polydisperse scale factor is indistinguishable from a monodisperse scale factor equal to the weighted average of the polydisperse scale factor.
Is solvent fraction ''x'' supposed to be polydisperse? In which case with different spheres absorbing different amounts of solvent, shouldn't the underlying ''radius'' be increased and ''sld'' adjusted toward ''sld_solvent'' as solvent fraction increases? As it is now, being a scale factor on the sphere form, there is no reason to make it polydisperse.
As contrast is reduced by solvent fraction in the sphere, shouldn't the sphere form factor be reduced by the squared fraction? This would occur automatically if ''sld'' were adjusted toward ''sld_solvent'' by factor ''(1-x)''.
Migrated from http://trac.sasview.org/ticket/605
The text was updated successfully, but these errors were encountered: