#Aka “How to get my pull-request accepted”
- The code is not complete until there are unit tests.
- The PR won't be accepted until there are integration tests.
- Code tells you how, comments tell you why.
- Simple is better than complex. Complex is better than complicated.
\n
is the one true line ending.\r\n
and\r
lead to woe and the wall of pink.- Write useful commit messages.
- Do commit frequently and rebase as necessary.
- Don't vent your frustrations in the commit message; a blank line is more useful.
#Things that will make the workflow delightful
- Use the JIRA integration in your branch names, commit messages, and pull requests.