Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement method Slice in DataStream #143

Closed
pleonex opened this issue Sep 21, 2020 · 0 comments · Fixed by #204
Closed

Implement method Slice in DataStream #143

pleonex opened this issue Sep 21, 2020 · 0 comments · Fixed by #204
Assignees
Labels
enhancement good first issue Easy issues to start with the project
Milestone

Comments

@pleonex
Copy link
Member

pleonex commented Sep 21, 2020

Similar to how Span works, we could add a method to the DataStream class to easily create a substream. We could name it Slice and it would equivalent to call the constructor with the given offset and size. This may simplify APIs.

var parent = new DataStream();
var sub = parent.Slice(4, 0x10);

Additional context
We could review the other methods that Span provides so we can have similar names.

@pleonex pleonex added enhancement good first issue Easy issues to start with the project labels Sep 21, 2020
@pleonex pleonex added this to the vNext milestone Sep 21, 2020
@pleonex pleonex modified the milestones: vNext, Future Dec 23, 2020
@pleonex pleonex moved this to In Progress in SceneGate Framework 1.0 Oct 16, 2021
@pleonex pleonex removed this from the vNext milestone Dec 5, 2021
@pleonex pleonex moved this from In Progress to Todo in SceneGate Framework 1.0 Nov 16, 2023
@pleonex pleonex added this to the vNext milestone Nov 18, 2023
@pleonex pleonex self-assigned this Nov 24, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in SceneGate Framework 1.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Easy issues to start with the project
Projects
Status: Done
1 participant