Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod uses old (no more working) ACE uncon detection #11

Open
drzdo opened this issue Aug 12, 2024 · 3 comments
Open

Mod uses old (no more working) ACE uncon detection #11

drzdo opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@drzdo
Copy link

drzdo commented Aug 12, 2024

Ref acemod/ACE3#7818

Checks like

!(_x getVariable ["ACE_isUnconscious",false])

should be replaced with

([_x] call ace_common_fnc_isAwake) &&
@SceptreOfficial
Copy link
Owner

SceptreOfficial commented Aug 13, 2024

ace_common_fnc_isAwake still primarily uses that variable to check for uncon:
https://github.com/acemod/ACE3/blob/master/addons/common/functions/fnc_isAwake.sqf#L20
I don't think it would change the results in this mod right now to switch the conditions to use that function call, unless I'm missing something...

That issue you referenced probably stemmed from not checking the the alive state as well.

@SceptreOfficial SceptreOfficial self-assigned this Aug 13, 2024
@SceptreOfficial SceptreOfficial added the bug Something isn't working label Aug 13, 2024
@drzdo
Copy link
Author

drzdo commented Aug 13, 2024

Hm, I see now that you're right. Then I'm not sure here - I believe (though no 100% certainty) that I did hear voice overs like "teammate down" from unconscious units.

@drzdo
Copy link
Author

drzdo commented Aug 14, 2024

I think it may be civilians shouting. Friendlies detection includes those on civilians side.
Makes sense to add check like

	(side group _x) isNotEqualTo civilian &&

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants