Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(business/autocomplete): expose autocomplete component for business #42

Merged
merged 10 commits into from
Jun 21, 2019

Conversation

efux
Copy link
Contributor

@efux efux commented Jun 19, 2019

Exposes the autocomplete component for business applications.

Styling should be according to the digital guidelines of SBB for business applications, except for the on-hover bar at the left side of the selected item.

This PR/Branch is based on #32 and #41. Therefore the other PRs should be merged first. The styling of the autocomplete component is done in those PRs.

business-autocomplete

Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the same issue as #41
Hovered/Active item should have a red bar on the left side (see https://digital.sbb.ch/de/webapps/components/autocompletion)

@efux efux requested a review from kyubisation June 21, 2019 09:40
@kyubisation
Copy link
Collaborator

@efux LGTM. Thank you once again. 😃

@kyubisation kyubisation merged commit b7ec7c0 into master Jun 21, 2019
@kyubisation kyubisation deleted the feature/business-autocomplete branch June 21, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants