fix: 400 error on the datasets page when changing the number of items per page #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpedersen2
approved these changes
Apr 4, 2024
Junjiequan
force-pushed
the
SWAP-3895-scicat-change-items-per-page-number-when-logged-i
branch
from
b7d8090
to
0151989
Compare
Junjiequan
force-pushed
the
SWAP-3895-scicat-change-items-per-page-number-when-logged-i
branch
from
0151989
to
5cb876e
Compare
Junjiequan
deleted the
SWAP-3895-scicat-change-items-per-page-number-when-logged-i
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the items-per-page value on the Datasets page throws a 400 Bad Request error.
Fixes:
replace misused DTO with the correct one for updateSettings API in users controller.
Changes:
Added API test for the fix
Tests included/Docs Updated?