Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jobs migration: schema #621

Closed
nitrosx opened this issue Jul 24, 2023 · 3 comments
Closed

Jobs migration: schema #621

nitrosx opened this issue Jul 24, 2023 · 3 comments
Assignees
@despadam
Labels
Release Jobs Jobs migration
Milestone
Release Jobs

Comments

@nitrosx
Copy link
Member

nitrosx commented Jul 24, 2023 •
edited
Loading

Summary

Refactor jobs schema including decorators for swagger
@nitrosx nitrosx added the Release Jobs Jobs migration label Jul 24, 2023
@nitrosx nitrosx added this to the Release 4.4 milestone Jul 24, 2023
@nitrosx nitrosx moved this to Todo in Core Release Jobs Aug 11, 2023
@ddijken ddijken moved this from Todo to Accepted in Core Release Jobs Oct 25, 2023
@nitrosx
Copy link
Member Author

nitrosx commented Oct 25, 2023

src/jobs/schema/jobs.schema.ts

@HayenNico HayenNico mentioned this issue Oct 30, 2023
Merged
5 tasks
@rkweehinzmann rkweehinzmann moved this from Accepted to In Progress in Core Release Jobs Nov 3, 2023
@despadam despadam assigned despadam and unassigned rkweehinzmann Apr 11, 2024
@despadam despadam mentioned this issue Apr 11, 2024
Closed
@despadam
Copy link
Member

Closing this one as Done. The final changes aiming for an MVP are included in #1265 , where we decided to store the full configuration in the Job schema, instead of only the configuration version.

@github-project-automation github-project-automation bot moved this from In Progress to Ready in Core Release Jobs Jun 17, 2024
@despadam despadam moved this from Ready to Done in Core Release Jobs Jun 21, 2024
@despadam despadam moved this from Done to In Progress in Core Release Jobs Jul 1, 2024
@despadam despadam reopened this Jul 1, 2024
@despadam
Copy link
Member

despadam commented Jul 1, 2024

Re-opening this issue as there are still some things to be fixed.

The current job.schema contains:

  • a property messageSent which is never used
  • properties datasetValidation and datasetsValidation. Only the second one is used, so we should remove the first one.

@despadam despadam mentioned this issue Jul 3, 2024
Merged
@despadam despadam moved this from In Progress to Done in Core Release Jobs Jul 8, 2024
@despadam despadam closed this as completed Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Done to Ready in Core Release Jobs Jan 8, 2025
@despadam despadam moved this from Ready to Done in Core Release Jobs Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@despadam despadam

Labels
Release Jobs Jobs migration
Projects
Core Release Jobs
Status: Done
Milestone
Release Jobs
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/621-jobs-migration-schema SciCatProject/scicat-backend-next
6 participants
@nitrosx @LAShemilt @despadam @ddijken @minottic @rkweehinzmann