Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test container for TestingCriteria #357

Closed
DavidKerkmann opened this issue Sep 2, 2022 · 1 comment · Fixed by #752 or #830
Closed

Test container for TestingCriteria #357

DavidKerkmann opened this issue Sep 2, 2022 · 1 comment · Fixed by #752 or #830
Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model.

Comments

@DavidKerkmann
Copy link
Member

For performance issues, we should test which data container should be used in TestingCriteria. For now, a vector is used, but a set or an unordered set might be better when having many lookups. This should be tested and changed, if another container is faster.
@DavidKerkmann DavidKerkmann added good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model. class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues labels Sep 2, 2022
@DavidKerkmann DavidKerkmann moved this to Product Backlog in MEmilio: Agent-Based-Model Sep 2, 2022
@DavidKerkmann
Copy link
Member Author

Also possible would be to have a vector of booleans for each criterion (age/infection state/location) with true and false values according to the object's desires. This would allow for a fast look-up with index referencing.

@khoanguyen-dev khoanguyen-dev linked a pull request Nov 10, 2023 that will close this issue
369 allowing tests to be performed at individual locations not only location types #752
Merged
10 tasks
@DavidKerkmann DavidKerkmann mentioned this issue Nov 24, 2023
Merged
10 tasks
@DavidKerkmann DavidKerkmann moved this from Product Backlog 📕 to Review 🕵️‍♂️ in MEmilio: Agent-Based-Model Development Dec 12, 2023
@github-project-automation github-project-automation bot moved this from Review 🕵️‍♂️ to Done (Sprint) 🎉 in MEmilio: Agent-Based-Model Development Dec 20, 2023
@DavidKerkmann DavidKerkmann moved this from Done (Sprint) 🎉 to Done (Total) 💯 in MEmilio: Agent-Based-Model Development Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Done (Total) 💯
Milestone
No milestone
1 participant
@DavidKerkmann