Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload coverage data to coveralls/codecov #16

Open
ranocha opened this issue Jul 29, 2024 · 3 comments
Open

Upload coverage data to coveralls/codecov #16

ranocha opened this issue Jul 29, 2024 · 3 comments

Comments

@ranocha
Copy link
Member

ranocha commented Jul 29, 2024

Codecov on forks is broken though at the Codecov service level, so we may just need to globally move everything to coveralls.

Mentioned by @ChrisRackauckas in SciML/RootedTrees.jl#170 (comment)

@ChrisRackauckas
Copy link
Member

@thazhemadam what would you recommend here?

@thazhemadam
Copy link
Member

I think for starters, having codecov run on PRs made directly from within the repos (i.e., not from forks) and on the default branch should prove to be sufficient. I've noticed that the latter doesn't work as intended.
I haven't looked much into Coveralls or their open source plans to comment on that just yet.

@ranocha
Copy link
Member Author

ranocha commented Aug 1, 2024

Using Codecov at least for pushes to the main branch would already be nice and improve the status quo. Everything in addition would be very nice to have.

Re Coveralls: You have deleted some working Coveralls code from RootedTrees.jl. It is a bit tricky to get correct coverage with parallel builds, but once everything is set up, it woks well. So far, I have not encountered issues with PRs from forks etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants