New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridSample appears to sample on a line #93

Closed

frankier opened this issue Nov 2, 2023 · 1 comment

frankier commented Nov 2, 2023

It looks like GridSample is generating points in a line. I would expect the points to form a grid.

> using QuasiMonteCarlo
> QuasiMonteCarlo.sample(5, [-6.0, -6.0], [6.0, 6.0], GridSample())
2×5 Matrix{Float64}:
 -4.8  -2.4  0.0  2.4  4.8
 -4.8  -2.4  0.0  2.4  4.8

The text was updated successfully, but these errors were encountered:

Member

ChrisRackauckas commented Nov 16, 2023

Solved and tested better in #94. It was somewhat ill-defined what it's behavior truly was, so that was clarified as well:

A simple rectangular grid lattice. Samples n random samples from a grid with `dx = (ub -lb)/n``

ChrisRackauckas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment