Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in 08 Kolmogorov.jl #168

Closed
finmod opened this issue Jun 14, 2020 · 10 comments · Fixed by #169
Closed

Bug in 08 Kolmogorov.jl #168

finmod opened this issue Jun 14, 2020 · 10 comments · Fixed by #169

Comments

@finmod
Copy link

finmod commented Jun 14, 2020

In m = fmap(cpu , m) "cu" should be "cpu"

@finmod
Copy link
Author

finmod commented Jun 14, 2020

And another one further down:

prob = SDEProblem(f_val,g_val,u₀,tspan) instead of prob = SDEProblem(f,g,u₀,tspan)

For: @time sol = solve(prob, NeuralNetDiffEq.NNKolmogorov(m, opt, sdealg, ensemblealg), verbose = true, dt = dt,
dx = dx , trajectories = trajectories , abstol=1e-6, maxiters = 3000)

takes:
Current loss is: 288.77471066944065
Current loss is: 288.7747063768811
15327.516623 seconds (174.48 G allocations: 9.600 TiB, 11.89% gc time)
([105.83 108.06 … 105.32 107.2], Float32[11.2977295 10.500775 … 11.479994 10.80812])

4 hours and 15 minutes!!!

@ChrisRackauckas
Copy link
Member

I haven't built it yet to see. @ashutosh-b-b that looks incorrect though if the loss doesn't change?

@finmod
Copy link
Author

finmod commented Jun 14, 2020

Also add 'using Distributions' to calculate mean(phi)

@ChrisRackauckas
Copy link
Member

using Statistics I think

@ChrisRackauckas
Copy link
Member

@ashutosh-b-b it's worth a few fixes here. Notice I refactored a bit in #169

@ChrisRackauckas ChrisRackauckas changed the title Bug in 06 Kolmogorov.jl Bug in 08 Kolmogorov.jl Jun 29, 2020
@ChrisRackauckas
Copy link
Member

rebuild! advanced/03-kolmogorov_equations

@ChrisRackauckas
Copy link
Member

!rebuild advanced/03-kolmogorov_equations.jmd

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2020

Created pipeline: see it here.

@ChrisRackauckas
Copy link
Member

Fixed!

@finmod
Copy link
Author

finmod commented Jul 2, 2020

Great. 427 seconds by steeping back to CuArrays and CUDAnative. Hopefully, CUDA.jl on Windows will pass its tests soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants