Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer in scripts #48

Closed
isaacsas opened this issue Mar 10, 2019 · 5 comments
Closed

footer in scripts #48

isaacsas opened this issue Mar 10, 2019 · 5 comments

Comments

@isaacsas
Copy link
Member

At the end of scripts the following code gets added, but seems not to be run-able:

using DiffEqTutorials
DiffEqTutorials.tutorial_footer(WEAVE_ARGS[:folder],WEAVE_ARGS[:file])

Should this be removed from .jl files?

@ChrisRackauckas
Copy link
Member

Yes, it probably should. I'm not sure if it's possible from Weave though since those are generated by a tangle, and I'm not sure there's a "don't tangle" argument for a block. @mpastell

@isaacsas
Copy link
Member Author

isaacsas commented Mar 10, 2019

A second issue is that I get an error about trying to display nothing in the generated html file:
Fixed on master...

ERROR: ArgumentError: `nothing` should not be printed; use `show`, `repr`, or custom output instead.

This is using the corrected footer:

```julia echo=false; skip="notebook"
using DiffEqTutorials
DiffEqTutorials.tutorial_footer(WEAVE_ARGS[:folder],WEAVE_ARGS[:file])
```

~

@ChrisRackauckas
Copy link
Member

On latest master?

https://github.com/JuliaDiffEq/DiffEqTutorials.jl/blob/master/src/DiffEqTutorials.jl#L94

This was added to stop the nothing print issue.

@isaacsas
Copy link
Member Author

Darn, sorry about that -- I missed that master had been updated... That fixes it.

@mpastell
Copy link

Yes, it probably should. I'm not sure if it's possible from Weave though since those are generated by a tangle, and I'm not sure there's a "don't tangle" argument for a block. @mpastell

There is, you can use tangle=false chunk option http://weavejl.mpastell.com/stable/chunk_options/#Options-for-code-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants