Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Package breaks stacktraces #18

Closed
KristofferC opened this issue Mar 13, 2023 · 3 comments
Closed

Package breaks stacktraces #18

KristofferC opened this issue Mar 13, 2023 · 3 comments

Comments

@KristofferC
Copy link

julia> @snoopr using DiffEqBase
7913-element Vector{Any}:
Error showing value of type Vector{Any}:
ERROR: UndefVarError: `isinplace` not defined

Some of the types have been truncated in the stacktrace for improved reading. To emit complete information
in the stack trace, evaluate `TruncatedStacktraces.VERBOSE[] = true` and re-run the code.

Stacktrace:
  [1] show(io::IOContext{IOBuffer}, t::
SYSTEM (REPL): showing an error caused an error

Honestly, this is just BS. Do you guys hate people trying to improve the SciML ecosystem?

@devmotion
Copy link
Member

Other people have noticed this as well: SciML/SciMLBase.jl#409

@thomvet
Copy link

thomvet commented Mar 15, 2023

Apart from the whole invalidation issue, is it possible that some of the defined show(…) methods are simply bugged (using variables that are not defined)?

@ChrisRackauckas
Copy link
Member

#19 adds safety to the macro in the non-verbose case, same as SciML/SciMLBase.jl#419. #20 now states everything should use the macro to avoid any bugged show methods. And a preference exists to remove all of the invalidations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants