-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci broken #49
Comments
at the moment I would not know what to look for. one option would be to temporarily revert the async build in nimibook. |
If you expect a file that is created on the result of an async proc you should have a Future[T] variable you can await no ? |
here is the file and proc where the async build is done (and above in I am very weak on async so I cannot really tell if there is a bug or not. on the matter of why CI is breaking, looking at #50 (which has no async build) it seems there is some issue with datamancer possibly related to an updated version. |
mmh, no, since the error is called in this line it seems that after the error when running basics/data_wrangling.nim it is not actually able to open the log file to write the log. Maybe at that point the folder it was supposed to be in changed and the path is no longer valid? it should probably use an absolute path and not a relative one... |
after merging #47 the CI broke: https://github.com/SciNim/getting-started/actions/runs/3136348556/jobs/5093144122
It seems there was some error when running
basics/data_wrangling.nim
so a log should have been created but it is not found (maybe it failed too fast). this is a bit complicated due to async processing added to nimibook in pietroppeter/nimibook#53, not sure if @beef331 can help here. I am currently thinking we might want to have an option in nimibook to disable the async processing in nimibook for better troubleshooting these cases.The text was updated successfully, but these errors were encountered: