Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuda >= 11.7 support #14

Closed
dlesnoff opened this issue Aug 1, 2022 · 7 comments
Closed

Cuda >= 11.7 support #14

dlesnoff opened this issue Aug 1, 2022 · 7 comments

Comments

@dlesnoff
Copy link

dlesnoff commented Aug 1, 2022

What would this take to add support for cuda 11.7 ?

@Vindaar
Copy link
Member

Vindaar commented Aug 4, 2022

It depends, in principle not much.

The question is what of the API has changed and if it's easier to simply regenerate the full wrapper or to manually add the changes.

@dlesnoff
Copy link
Author

@lilkeet Thanks so much! Going to try it out this week-end hopefully

@dlesnoff
Copy link
Author

I have been able to compile and run successfully two examples out of three.

Warnings in random. (We might want to desactivate the warnings in the .nimble file rather than removing these else's that serve as extra checks well).

~/Documents/dev/nimcuda/src/nimcuda/cuda12_5/cuda_occupancy.nim(799, 5) Warning: unreachable else, all cases are already covered [UnreachableElse]
~/Documents/dev/nimcuda/src/nimcuda/cuda12_5/cuda_occupancy.nim(842, 5) Warning: unreachable else, all cases are already covered [UnreachableElse]
~/.cache/nim/fft_d/@m..@s..@ssrc@snimcuda@scuda12_5@scufft.nim.c:94:10: fatal error: vector_types.h: No such file or directory
   94 | #include "vector_types.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
~/.cache/nim/fft_d/@mfft.nim.c:94:10: fatal error: vector_types.h: No such file or directory
   94 | #include "vector_types.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

Note: I installed Cuda 12.6.2 on my system.

@lilkeet
Copy link
Contributor

lilkeet commented Oct 13, 2024

Warnings in random. (We might want to desactivate the warnings in the .nimble file rather than removing these else's that serve as extra checks well).

agreed. either there or via a push + pop pragma.

~/.cache/nim/fft_d/@m..@s..@ssrc@snimcuda@scuda12_5@scufft.nim.c:94:10: fatal error: vector_types.h: No such file or directory
   94 | #include "vector_types.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.
~/.cache/nim/fft_d/@mfft.nim.c:94:10: fatal error: vector_types.h: No such file or directory
   94 | #include "vector_types.h"
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

Note: I installed Cuda 12.6.2 on my system.

right now, the nimble file's exampleConfig proc assumes that you have the exact version installed that the library is targeting. in this case, 12.5. since ur installed version is 12.6, the directory for 12.5's include directory doesn't exist and it cant find the vector_types header. this isn't an issue for when you actually use the library in your code, as you would have to pass ur install location explicitly via -cincludes:"path/to/cudaVer/include" and -clibdir:"path/to/cudaVer/lib64".

@dlesnoff
Copy link
Author

dlesnoff commented Oct 20, 2024

The bizarre thing is that random and blas examples work well in my case while fft example doesn't, thus it must not be a problem of versioning.
The fft example needs to be updated for 12.5 by removing the import related to vector_types.

EDIT: the issue is probably stemming from the non-generated cufft wrapper #24

@lilkeet
Copy link
Contributor

lilkeet commented Oct 20, 2024

works on my machine ¯\(ツ)/¯

@dlesnoff
Copy link
Author

I managed to compile it by fixing the paths as described in #25.
Thank you very much for bringing the library back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants