-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No floored division and modulo operations in IntRing, ShortRing, ByteRing and LongRing #103
Comments
I'm not sure how faithful kmath about algebra abstractions. But rings don't have division. You'll get field if you want to add division. Also while it's possible to define Field for word32/word64. Its division is completely different from usual rounded down division. |
Those operations are not a part of |
It does. For example, for |
@Shimuuar Ring does not have division. It has only multiplication. |
I suggest introducing new interface, something like:
|
There are no
div
andmod
operations in integer typed rings. They have some use cases in basic arithmetics, so I think, integer algebra is inconsistent without them.The text was updated successfully, but these errors were encountered: