Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include date in headers #340

Closed
rgbkrk opened this issue May 24, 2024 · 7 comments · Fixed by #342
Closed

Include date in headers #340

rgbkrk opened this issue May 24, 2024 · 7 comments · Fixed by #342

Comments

@rgbkrk
Copy link

rgbkrk commented May 24, 2024

When testing out this kernel with zed-industries/zed#12062, I noticed that date is not in the headers. I'd love to see that added in so that I don't have to make date optional in my rust structures.

@kojix2
Copy link
Member

kojix2 commented May 24, 2024

Hi @rgbkrk

Thank you for your report.
IRuby currently has no active developers and has no plans to keep up with the latest Jupyter protocol.
Still, I would like to hear a little more detail on your report.

If I understand correctly, you are reporting that the Message Header does not contain a date field, right?

Maybe we can modify the code here to add a date field...

header = {
msg_type: message_type,
msg_id: SecureRandom.uuid,
username: 'kernel',
session: @session_id,
version: '5.0'
}

@rgbkrk
Copy link
Author

rgbkrk commented May 24, 2024

You don't have to implement all the messages, but I'd at least bring it up to version 5.1 compliance where date is a required field. https://jupyter-client.readthedocs.io/en/latest/messaging.html

@rgbkrk
Copy link
Author

rgbkrk commented Jul 18, 2024

Thank you @ebababi! @kojix2, who has the ability to ship a patch release of the gem for iruby?

@kojix2 kojix2 reopened this Jul 18, 2024
@kojix2
Copy link
Member

kojix2 commented Jul 18, 2024

The owners of the gem are @minad, @mrkn, @domitry, @v0dro, and @kozo2.

@kozo2
Copy link
Contributor

kozo2 commented Jul 23, 2024

@kojix2 Can I ask you to ship that release? I invited you to the owner of https://rubygems.org/gems/iruby .

@kojix2
Copy link
Member

kojix2 commented Jul 23, 2024

Sure, @kozo2. Thank you for the invitation.
I will review the changes and would like to proceed with shipping the release soon.

@kojix2 kojix2 mentioned this issue Jul 26, 2024
@kojix2
Copy link
Member

kojix2 commented Jul 28, 2024

Version 0.8.0 has been uploaded to the rubygem server. There may still be room for improvement. If you find ways to improve it, pull requests are welcome.

@kojix2 kojix2 closed this as completed Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants