Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np class is not static in np.module.gen.cs #7

Open
epignatelli opened this issue Jul 30, 2019 · 4 comments
Open

np class is not static in np.module.gen.cs #7

epignatelli opened this issue Jul 30, 2019 · 4 comments

Comments

@epignatelli
Copy link
Contributor

Is it a special case, or is it just lapse?

@henon
Copy link
Contributor

henon commented Jul 30, 2019

it should be static, this is a bug

@epignatelli
Copy link
Contributor Author

epignatelli commented Jul 30, 2019

Thanks @henon.

I am going through the code since I am trying to port some of the projects in your stack to a visual programming interface.
I might find this small stuff, I am keen to push a fix here and there (I do it locally anyway).
What's your usual workflow for contributing?

@henon
Copy link
Contributor

henon commented Jul 30, 2019

Any help is appreciated. If you fix bugs or improve anything please send a PR, we'll review and merge all acceptable changes.

Be sure not to make manual changes in generated files! Instead the generator has to be fixed (this is one of those cases). When changing the generator generate the code for Numpy.NET and Torch.NET and check the changes in the generated code (i.e. by looking over the git diff) to see that nothing broke. When you check in changes in the generator, please also check in the changes it has on the generated code of the projects Numpy.NET and Torch.NET.

@epignatelli
Copy link
Contributor Author

Thanks @henon for the guidance, I'll ring a pr in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants