Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Bad Typo in LLama/Extensions/IContextParamsExtensions.cs ? #805

Closed
SerialKicked opened this issue Jun 27, 2024 · 2 comments · Fixed by #806
Closed

[BUG]: Bad Typo in LLama/Extensions/IContextParamsExtensions.cs ? #805

SerialKicked opened this issue Jun 27, 2024 · 2 comments · Fixed by #806
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SerialKicked
Copy link
Contributor

SerialKicked commented Jun 27, 2024

Description

While i was looking around the code trying to figure a few issues compared to base LLama.cpp (memory consumption and repetition penalty doing weird things), I found this:

result.type_k = @params.TypeK ?? GGMLType.GGML_TYPE_F16;
result.type_k = @params.TypeV ?? GGMLType.GGML_TYPE_F16;

param.TypeV and param.TypeK are both assigned to result.type_k

I'm not exactly an expert in LLama.cpp / GGUF architecture, but it seems there's a mix-up.

Reproduction Steps

N/A

Environment & Configuration

  • Operating system: Win11
  • .NET runtime version: 8.0
  • LLamaSharp version: 0.13
  • CUDA version (if you are using cuda backend): 12
  • CPU & GPU device: RTX3060 12GB

Known Workarounds

No response

@martindevans
Copy link
Member

That's definitely a bug! If you'd like to make a PR to fix it that would be appreciated :)

@martindevans martindevans added good first issue Good for newcomers bug Something isn't working labels Jun 27, 2024
@SerialKicked
Copy link
Contributor Author

Sure thing, if you can wait until this week-end (otherwise, feel free to change the line, I won't mind.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants