Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark lazy regridding #100

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

stephenworsley
Copy link
Contributor

Similar to #98 except for cubes with lazy data.

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #100 (7981845) into main (534fcaf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          14       14           
  Lines         678      678           
=======================================
  Hits          670      670           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534fcaf...7981845. Read the comment docs.

Copy link
Member

@jamesp jamesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of comments inline

benchmarks/benchmarks/ci/esmf_regridder.py Show resolved Hide resolved
benchmarks/benchmarks/ci/esmf_regridder.py Outdated Show resolved Hide resolved
benchmarks/benchmarks/ci/esmf_regridder.py Show resolved Hide resolved
@trexfeathers
Copy link
Contributor

@jamesp anything left before this can be merged?

@jamesp
Copy link
Member

jamesp commented Aug 18, 2021

Seems good to me, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants