-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Curvilinear Support #125
Conversation
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 98.85% 99.10% +0.24%
==========================================
Files 14 14
Lines 699 1005 +306
==========================================
+ Hits 691 996 +305
- Misses 8 9 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @stephenworsley some comments inline.
There is a comment at L90 of _esmf_sdo.py, can that be removed now?
Also I think the signatures of some functions in the docstrings need updating as they reference 1d objects, but if I understand your code correctly that may no longer be true! 🎉
And finally a more general point, it might be useful to start thinking about documentation for this - either as comments in the code or in an rst file somewhere. What can it do, what can't it do, perhaps a table of compatibility?!
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Looks good to go 👍 Things to do after this is merged:
|
Adds support for either the source or target grid to be curvilinear (described by 2d coordinates).