Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curvilinear Support #125

Merged
merged 20 commits into from
Dec 20, 2021
Merged

Add Curvilinear Support #125

merged 20 commits into from
Dec 20, 2021

Conversation

stephenworsley
Copy link
Contributor

Adds support for either the source or target grid to be curvilinear (described by 2d coordinates).

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #125 (7cd77d7) into main (e528cbf) will increase coverage by 0.24%.
The diff coverage is 99.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   98.85%   99.10%   +0.24%     
==========================================
  Files          14       14              
  Lines         699     1005     +306     
==========================================
+ Hits          691      996     +305     
- Misses          8        9       +1     
Impacted Files Coverage Δ
esmf_regrid/schemes.py 98.24% <97.56%> (-0.70%) ⬇️
esmf_regrid/_esmf_sdo.py 96.96% <100.00%> (+1.13%) ⬆️
esmf_regrid/tests/unit/_esmf_sdo/test_GridInfo.py 100.00% <100.00%> (ø)
...sts/unit/schemes/test_ESMFAreaWeightedRegridder.py 100.00% <100.00%> (ø)
...egrid/tests/unit/schemes/test__cube_to_GridInfo.py 100.00% <100.00%> (ø)
.../schemes/test_regrid_rectilinear_to_rectilinear.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e528cbf...7cd77d7. Read the comment docs.

Copy link
Member

@jamesp jamesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @stephenworsley some comments inline.

There is a comment at L90 of _esmf_sdo.py, can that be removed now?
Also I think the signatures of some functions in the docstrings need updating as they reference 1d objects, but if I understand your code correctly that may no longer be true! 🎉

And finally a more general point, it might be useful to start thinking about documentation for this - either as comments in the code or in an rst file somewhere. What can it do, what can't it do, perhaps a table of compatibility?!

esmf_regrid/_esmf_sdo.py Outdated Show resolved Hide resolved
esmf_regrid/_esmf_sdo.py Outdated Show resolved Hide resolved
esmf_regrid/_esmf_sdo.py Outdated Show resolved Hide resolved
esmf_regrid/_esmf_sdo.py Show resolved Hide resolved
esmf_regrid/schemes.py Show resolved Hide resolved
esmf_regrid/schemes.py Outdated Show resolved Hide resolved
esmf_regrid/schemes.py Show resolved Hide resolved
esmf_regrid/schemes.py Show resolved Hide resolved
esmf_regrid/schemes.py Outdated Show resolved Hide resolved
@jamesp jamesp marked this pull request as ready for review December 20, 2021 15:15
@jamesp
Copy link
Member

jamesp commented Dec 20, 2021

Looks good to go 👍

Things to do after this is merged:

  • Bump version number to 0.3.0 and tag as release
  • Add 0.3.0 changes to the changelog
  • Bump version number to 0.4.dev0.
  • schemes.py#L36 needs an issue to track the additional checks required. Add to backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants