-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic API Documentation #155
Conversation
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 27 27
Lines 2073 2073
=======================================
Hits 2064 2064
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as far as improving the docstrings go. I just have the one comment regarding what was already a typo. I think there are probably cases where I'd want to rethink some of the docstrings as part of a larger overhaul, but I'd say that should be considered outside the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trexfeathers Awesome LGTM.
Just a minor question to service, but let's get this banked 💯 👨🎤
docs = | ||
pydata-sphinx-theme | ||
sphinx | ||
sphinx-copybutton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sphinxcontrib-apidoc
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just some minor tweaks and I think we're good.
this cube will be converted to values on the new grid using | ||
:class:`iris.cube.Cube` | ||
A :class:`~iris.cube.Cube` defined with the horizontal dimensions of the target | ||
and the other dimensions from this :class:`~iris.cube.Cube`. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should refer to the argument "cube" rather than the class "Cube".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cube will be converted to values on the new grid using | ||
:class:`iris.cube.Cube` | ||
A :class:`~iris.cube.Cube` defined with the horizontal dimensions of the target | ||
and the other dimensions from this :class:`~iris.cube.Cube`. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should refer to the argument "cube" rather than the class "Cube".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Here is a rendered example on Read the Docs