Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic API Documentation #155

Merged
merged 17 commits into from
Feb 23, 2022
Merged

Automatic API Documentation #155

merged 17 commits into from
Feb 23, 2022

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Feb 23, 2022

  • Create Sphinx configuration
  • Create Read the Docs configuration
  • Populate docstrings with Sphinx domains

Here is a rendered example on Read the Docs

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #155 (f63a740) into main (1aa8052) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          27       27           
  Lines        2073     2073           
=======================================
  Hits         2064     2064           
  Misses          9        9           
Impacted Files Coverage Δ
esmf_regrid/_esmf_sdo.py 96.96% <ø> (ø)
esmf_regrid/esmf_regridder.py 94.54% <ø> (ø)
esmf_regrid/experimental/io.py 100.00% <ø> (ø)
esmf_regrid/experimental/unstructured_regrid.py 100.00% <ø> (ø)
esmf_regrid/experimental/unstructured_scheme.py 100.00% <ø> (ø)
esmf_regrid/schemes.py 98.24% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa8052...f63a740. Read the comment docs.

LICENSE Show resolved Hide resolved
@trexfeathers
Copy link
Contributor Author

Here is a rendered example on Read the Docs

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as improving the docstrings go. I just have the one comment regarding what was already a typo. I think there are probably cases where I'd want to rethink some of the docstrings as part of a larger overhaul, but I'd say that should be considered outside the scope of this PR.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trexfeathers Awesome LGTM.

Just a minor question to service, but let's get this banked 💯 👨‍🎤

docs =
pydata-sphinx-theme
sphinx
sphinx-copybutton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sphinxcontrib-apidoc here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE Show resolved Hide resolved
@trexfeathers trexfeathers marked this pull request as ready for review February 23, 2022 17:21
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just some minor tweaks and I think we're good.

this cube will be converted to values on the new grid using
:class:`iris.cube.Cube`
A :class:`~iris.cube.Cube` defined with the horizontal dimensions of the target
and the other dimensions from this :class:`~iris.cube.Cube`. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should refer to the argument "cube" rather than the class "Cube".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cube will be converted to values on the new grid using
:class:`iris.cube.Cube`
A :class:`~iris.cube.Cube` defined with the horizontal dimensions of the target
and the other dimensions from this :class:`~iris.cube.Cube`. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should refer to the argument "cube" rather than the class "Cube".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bjlittle bjlittle merged commit f0e2259 into SciTools:main Feb 23, 2022
@trexfeathers trexfeathers deleted the rtd branch March 31, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants