Make weights array handling more robust #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 99.51% 99.51%
=======================================
Files 27 27
Lines 2469 2469
=======================================
Hits 2457 2457
Misses 12 12
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
trexfeathers
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With scipy.sparse now offering arrays as well as matrices, the code ought to be improved so that it can work with either matrices or arrays representing the weights, especially since precomputed weights could potentially be given in either form. This also clarifies in the code where matrix multiplication is happening rather than array multiplication.