Unpin python #208
Merged
Unpin python #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 99.38% 99.35% -0.04%
==========================================
Files 28 28
Lines 2785 2786 +1
==========================================
Hits 2768 2768
- Misses 17 18 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjlittle
requested changes
Sep 9, 2022
There was a problem hiding this comment.
@stephenworsley Awesome, this looks great 👍
There is also an opportunity to fold in some other minor associated changes:
- In setup.cfg line+11 update the PyPI Trove Classifers to state that you also support Python
3.9and3.10i.e., include
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
- Update the latest requirements symbolic link
requirements/dev.yml -> py310.yml - Consider updating the
.cirrus.ymlsuch that test coverage is performed on the latest available version of Python i.e.,3.10, see here.
bjlittle
approved these changes
Sep 9, 2022
|
@stephenworsley Once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables testing and releasing for python 3.9 and 3.10. Addresses #161, replaces #163.