Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow regridding of cubes with multiple coordinates per axis #217

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

stephenworsley
Copy link
Contributor

Addresses #216

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #217 (83f5012) into main (7d6f568) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   99.35%   99.36%           
=======================================
  Files          28       28           
  Lines        2786     2829   +43     
=======================================
+ Hits         2768     2811   +43     
  Misses         18       18           
Impacted Files Coverage Δ
esmf_regrid/experimental/unstructured_scheme.py 98.50% <100.00%> (ø)
esmf_regrid/schemes.py 97.77% <100.00%> (+0.12%) ⬆️
...sts/unit/schemes/test_ESMFAreaWeightedRegridder.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @stephenworsley! Just a couple of changes, and could you make a CHANGELOG entry?

stephenworsley and others added 2 commits October 19, 2022 11:57
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants