-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lazy regridding #80
Conversation
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 98.82% 98.85% +0.03%
==========================================
Files 14 14
Lines 678 699 +21
==========================================
+ Hits 670 691 +21
Misses 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a good, a couple of minor points inline
esmf_regrid/tests/unit/schemes/test_regrid_rectilinear_to_rectilinear.py
Show resolved
Hide resolved
When this is merged, the performance test in #100 will be measuring the set up for lazy regridding but not the final realisation of the data. The realisation will also be worth measuring after this is merged in (I don't think it will make sense to add such a test before this is merged in since then it would be measuring the realisation of an already realised array). |
830cc88
to
2e604e6
Compare
OK I'm happy with this. Any last changes @stephenworsley ? |
Provides lazy regridding through essentially the same means as in iris (introduced in this PR SciTools/iris#3701).