TST: Add a fixture enabling SRTM login using envvars. #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set SRTM_USERNAME and SRTM_PASSWORD in the environment, you can run pytest and have the SRTM tests work.
|
Note, you will need to try this out locally since we don't have the envvars set on any CI. |
Either we have no credentials and the tests will be skipped, or we do have the credentials and they will pass, so there's no need to show the warning. This needed moving the warning around a bit so it's not triggered just by importing the srtm package.
dopplershift
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There is currently no way to run SRTM tests, so they tend to fall into disrepair (cf #1080).
Implications
If you set
SRTM_USERNAMEandSRTM_PASSWORDin the environment, you can run pytest and have the SRTM tests work. In the future, we may want to define an encrypted variable on Travis to enable running these on CI. I don't want to do this myself as I'd rather someone from the Met Office handle the credentials.