Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equal Earth projection #1182

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Add Equal Earth projection #1182

merged 1 commit into from
Nov 14, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 13, 2018

Rationale

For the reasons outlined in #1156.

Implications

We can now plot on the Equal Earth projection, though it only works with Proj 5.2.0+.

Note: This depends on #1180 for the false_easting/false_northing handling in the warped rectangular class.

@pelson
Copy link
Member

pelson commented Nov 14, 2018

Please could you update this PR now that #1180 is merged @QuLogic? On the whole, this looks great - I see no reason for this to not be in the release, but haven't yet completed a full review.

@QuLogic QuLogic force-pushed the eqearth branch 3 times, most recently from 32d9022 to 89de50b Compare November 14, 2018 05:14
@QuLogic
Copy link
Member Author

QuLogic commented Nov 14, 2018

OK, looks like it's working, now that I figured out the Python 2 bugs.

@QuLogic
Copy link
Member Author

QuLogic commented Nov 14, 2018

Docs seem to downgrade to proj 4.9.3, so the projection is not being plotted in the list.

@pelson pelson merged commit ab6c3c9 into SciTools:master Nov 14, 2018
@pelson
Copy link
Member

pelson commented Nov 14, 2018

I've merged as the docs aren't a showstopper, and #1185 is moving us in the right direction.

Great addition. Thanks @QuLogic!

@QuLogic QuLogic deleted the eqearth branch November 14, 2018 06:24
@QuLogic QuLogic added this to the 0.17 milestone Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants