Vendor test decorator from MPL?

[oscargus]

Description

Matplotlib may deprecate the @cleanup test decorator matplotlib/matplotlib#22697 as it is no longer used in the Matplotlib code base. It was noted that Cartopy uses it, so my question now is where it should be vendored. To me it seems like creating a new file either testing.py or decorators.py may be options, possibly in the mpl directory. Or just add it to utils.py.

Any preferences?

(I can provide a PR, just in case.)

[dopplershift]

So it looks like @cleanup

1. Sets style (we never use and can handle with pytest-mpl)
2. Catches warnings
3. Resets the unit registry
4. Resets rcparams

(Did I miss anything?)

I don't know that we need any of that, except maybe the warning handling (which actually comes from the stdlib). So I'm wondering if we could just completely remove all uses?

[greglucas]

I agree with removing the cleanup decorator if possible. It works for me locally at least, see #2023

[QuLogic]

I don't know that we need any of that, except maybe the warning handling (which actually comes from the stdlib). So I'm wondering if we could just completely remove all uses?

We don't need this either; it's caught by pytest.

[oscargus]

Thanks all! Seems like it can work without it then. (The test failures in #2023 seems unrelated, so far.)

(This would then go in MPL 3.6, which is quite some time ahead, so should be plenty of time to get a Cartopy release out, if required. I guess all of you are at least as updated as I am when it comes to MPL releases, but in case someone else happens to see this.)