-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align long time interval check with cftime #274
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently blanket disallow
month
oryear
intervals when passing operations down to cftime:cf-units/cf_units/__init__.py
Lines 1932 to 1939 in 37c8400
cftime disallows these intervals, presumably because it requires consistent-length time increments. But cftime is more intelligent about this than cf-units is, e.g.
month
intervals are allowed for360_day
calendars (Unidata/cftime#75).We should make sure our own checks don't cover over details like the
360_day
exception. The Pythonic choice would be to do no extra checks at all in cf-units, simply relying on cftime to raise the appropriate error; is there a good reason why we don't do this?The text was updated successfully, but these errors were encountered: