Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle discontiguities and "bad geometries" hiding under masks #218

Closed
stephenworsley opened this issue Oct 18, 2022 · 1 comment · Fixed by #219
Closed

Handle discontiguities and "bad geometries" hiding under masks #218

stephenworsley opened this issue Oct 18, 2022 · 1 comment · Fixed by #219
Labels
New: Issue Highlight a new community raised "generic" issue

Comments

@stephenworsley
Copy link
Contributor

📰 Custom Issue

In many kinds of (curvilinear) grids, often ORCA grids, discontiguous bounds cause regridding to fail. If we were to ignore the check on contiguous bounds, this leads to the creatioj of a grid with "bad geometries" which causes problems for ESMF. In these cases, we tend to find that these discontiguous cells tend to be masked. It could be possible to convert such grids to a form which properly ignores these bad cells and has ESMF calculate only for the good cells. This could be done either by searching for discontiguities or by using the mask to determine which cells to ignore. Since we don't want regridders to depend on the data in general, this ignoring of masked cells ought to be controlled by a keyword.

One possible approach for handling of unmasked curvilinear cells would be to convert them into some kind of MeshInfo object, or else allow a GridInfo object to be represented as an ESMF mesh containing only the good cells. Alternatively, it's worth investigating the add_mask keyword for the ESMPy object ESMF.Grid to see if this works in a way which would solve this problem.

@stephenworsley stephenworsley added the New: Issue Highlight a new community raised "generic" issue label Oct 18, 2022
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This issue is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this issue will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Jan 17, 2023
@stephenworsley stephenworsley removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Jan 17, 2023
@stephenworsley stephenworsley moved this to 🆕 New in ESMValTool Feb 22, 2023
@stephenworsley stephenworsley linked a pull request Feb 22, 2023 that will close this issue
8 tasks
@trexfeathers trexfeathers moved this from 🆕 New to 📋 Backlog in ESMValTool Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New: Issue Highlight a new community raised "generic" issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant