Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Windows integration tests fail running through VS #113

Open
10 tasks
jrsurge opened this issue May 7, 2020 · 7 comments
Open
10 tasks

Windows integration tests fail running through VS #113

jrsurge opened this issue May 7, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@jrsurge
Copy link
Contributor

jrsurge commented May 7, 2020

On Windows, two integration tests fail in VS (building with VS triggers the testing):

  • test_images
15>------ Build started: Project: test_images, Configuration: Release x64 ------
15>configuring sclang to include Scintillator classes.
15>Traceback (most recent call last):
15>  File "C:/Users/jrsurge/Documents/Programming/Scintillator/tools/run-sclang.py", line 47, in <module>
15>    main(sys.argv[1:])
15>  File "C:/Users/jrsurge/Documents/Programming/Scintillator/tools/run-sclang.py", line 12, in main
15>    assert os.path.exists(sclang_path)
15>AssertionError
15>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(230,5): error MSB6006: "cmd.exe" exited with code 1.
15>Done building project "test_images.vcxproj" -- FAILED.
  • compare_images
16>------ Build started: Project: compare_images, Configuration: Release x64 ------
16>Traceback (most recent call last):
16>  File "../tools/compare-test-images.py", line 8, in <module>
16>    import yaml
16>ImportError: No module named 'yaml'
16>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(230,5): error MSB6006: "cmd.exe" exited with code 1.
16>Done building project "compare_images.vcxproj" -- FAILED.

test_images is being passed the wrong options?
compare_images is failing because of the Python install missing the yaml package.

Steps

  • Investigate options passing
  • Update Python install
    • Success
      • Require min version of Python on Windows
    • Failure
      • Install yaml package
        • Success
          • Require YAML package on Windows
        • Failure
          • Investigate
@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

Working on this right now. You will also need to install ImageMagick to do the image comparison. It needs the command line tool "compare.exe" which it uses for pixel comparison with reference images, and for generating the diff images that appear in the html report.

@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

(p.s. I would love to ultimately use Scintillator itself for image comparison)

@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

Oh, this is specific to Visual Studio. Yeah this stuff wasn't working on the command line, either. So my PR, while relevant, will not fix this issue. Sorry for the spam!

@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

Also, you will need to have run cmake with -DSCIN_SCLANG=<path to sclang.exe>

@jrsurge
Copy link
Contributor Author

jrsurge commented May 7, 2020

not sure these are specific to VS, just mentioned for completeness really.

The first issue will probably be resolved by that cmake flag, but I'll look at the python module thing

@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

for travis pyyaml install was:

git clone https://github.com/yaml/pyyaml/
cd pyyaml
python setup.py install

@lnihlen
Copy link
Member

lnihlen commented May 7, 2020

I'm working on adding windows support to tools/fetch_sclang.py which will fetch a limited (no IDE) supercollider build upload to s3 from the ScintillatorSynth/sclang-ext project.

@lnihlen lnihlen added the bug Something isn't working label Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants