Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhance] Add command to absolutely uninstall Windows-Terminal. #9546

Closed
hungpham3112 opened this issue Oct 23, 2022 · 3 comments
Closed

[Enhance] Add command to absolutely uninstall Windows-Terminal. #9546

hungpham3112 opened this issue Oct 23, 2022 · 3 comments

Comments

@hungpham3112
Copy link

image

Because Windows-Terminal uses OpenConsole as background process so when you uninstall it, you need to kill OpenConsole at first.
So I suggest to add

Stop-Process -Name OpenConsole

into windows-terminal uninstall script.
@HUMORCE
Copy link
Member

HUMORCE commented Oct 24, 2022 •
edited
Loading

this may terminate the process users working on.

@hungpham3112
Copy link
Author

We can print the message to warn users to close the Terminal. If they still want to uninstall then kill OpenConsole processes and uninstall Windows-Terminal.

this may terminate the process users working on.

@HUMORCE
Copy link
Member

HUMORCE commented Oct 26, 2022 •
edited
Loading

We can print the message to warn users to close the Terminal. If they still want to uninstall then kill OpenConsole processes and uninstall Windows-Terminal.

please re-check the contents of the screenshot you sent. scoop already prompted the app is still running in some instances.

see also: ScoopInstaller/Scoop#4713

@HUMORCE HUMORCE closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HUMORCE @hungpham3112