Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main/neofetch fails to install if git isn't installed #4056

Closed
milnak opened this issue Oct 24, 2022 · 2 comments · Fixed by ScoopInstaller/Scoop#5247
Closed

main/neofetch fails to install if git isn't installed #4056

milnak opened this issue Oct 24, 2022 · 2 comments · Fixed by ScoopInstaller/Scoop#5247
Labels
bug Something isn't working

Comments

@milnak
Copy link

milnak commented Oct 24, 2022

Bug Report

main/neofetch

Current Behaviour

On clean windows system, install scoop and then run scoop install neofetch

it will fail as (Get-Command git) throws an exception.

Expected Behaviour

Should attempt to scoop install git first, or should fail install with a clear message.

Additional context/output

ForEach-Object : Cannot bind argument to parameter 'Path' because it is null.

Possible Solution

Should attempt to scoop install git first, or should fail install with a clear message.

System details

Windows 10, 64-bit, PowerShell 5

Scoop Configuration

//# Your configuration here
@milnak milnak added the bug Something isn't working label Oct 24, 2022
@HUMORCE
Copy link
Member

HUMORCE commented Oct 24, 2022

Should attempt to scoop install git first

  • scoop accepts external installs of git
  • scoop cannot/will not force to install a git package. (scoop search git)

should fail install with a clear message.

It looks like this needs to be improved in Scoop Core.

@niheaven
Copy link
Member

A simple solution: change 'suggest gittodepends on git`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants