comments on deprecated MSI functions

lukesampson · lukesampson · commit 5be66873e562 · 2014-01-01T21:35:19.000+10:00
diff --git a/lib/install.ps1 b/lib/install.ps1
@@ -321,7 +321,7 @@ function run_installer($fname, $manifest, $architecture, $dir) {
 	}
 }
 
-# deprecated
+# deprecated (see also msi_installed)
 function install_msi($fname, $dir, $msi) {
 	$msifile = "$dir\$(coalesce $msi.file "$fname")"
 	if(!(is_in_dir $dir $msifile)) {
@@ -353,6 +353,7 @@ function extract_msi($path, $to) {
 	if(!$ok) { abort "failed to extract files from $path" }
 }
 
+# deprecated
 # get-wmiobject win32_product is slow and checks integrity of each installed program,
 # so this uses the [wmi] type accelerator instead
 # http://blogs.technet.com/b/heyscriptingguy/archive/2011/12/14/use-powershell-to-find-and-uninstall-software.aspx

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ function run_installer($fname, $manifest, $architecture, $dir) {`
`321`	`321`	`}`
`322`	`322`	`}`
`323`	`323`
`324`		`-# deprecated`
	`324`	`+# deprecated (see also msi_installed)`
`325`	`325`	`function install_msi($fname, $dir, $msi) {`
`326`	`326`	`$msifile = "$dir\$(coalesce $msi.file "$fname")"`
`327`	`327`	`if(!(is_in_dir $dir $msifile)) {`
`@@ -353,6 +353,7 @@ function extract_msi($path, $to) {`
`353`	`353`	`if(!$ok) { abort "failed to extract files from $path" }`
`354`	`354`	`}`
`355`	`355`
	`356`	`+# deprecated`
`356`	`357`	`# get-wmiobject win32_product is slow and checks integrity of each installed program,`
`357`	`358`	`# so this uses the [wmi] type accelerator instead`
`358`	`359`	`# http://blogs.technet.com/b/heyscriptingguy/archive/2011/12/14/use-powershell-to-find-and-uninstall-software.aspx`