install: Fix bug with Start-Process -Wait, exclusive to PowerShell Core on Windows 7 (#3415)

hpsbranco · r15ch13 · commit 70d6d9cab716 · 2019-04-29T17:24:27.000+02:00
Close: #2580 See: PowerShell/PowerShell#6561
diff --git a/lib/install.ps1 b/lib/install.ps1
@@ -696,7 +696,10 @@ function run($exe, $arg, $msg, $continue_exit_codes) {
             $parameters.arg = $arg;
         }
 
-        $proc = start-process $exe -wait -ea stop -passthru @parameters
+        # Don't use Start-Process -Wait
+        # https://github.com/PowerShell/PowerShell/issues/6561
+        $proc = start-process $exe -ea stop -passthru @parameters
+        $proc | Wait-Process
 
 
         if($proc.exitcode -ne 0) {

Original file line number	Diff line number	Diff line change
`@@ -696,7 +696,10 @@ function run($exe, $arg, $msg, $continue_exit_codes) {`
`696`	`696`	`$parameters.arg = $arg;`
`697`	`697`	`}`
`698`	`698`
`699`		`- $proc = start-process $exe -wait -ea stop -passthru @parameters`
	`699`	`+ # Don't use Start-Process -Wait`
	`700`	`+ # https://github.com/PowerShell/PowerShell/issues/6561`
	`701`	`+ $proc = start-process $exe -ea stop -passthru @parameters`
	`702`	`+ $proc \| Wait-Process`
`700`	`703`
`701`	`704`
`702`	`705`	`if($proc.exitcode -ne 0) {`