fix(psmodules): Remove folder recursively when unlinking previous module path (#5127)

AkariiinMKII · niheaven · web-flow · commit 740322f74f4f · 2022-08-29T21:50:27.000+05:30
* Update psmodules.ps1

* Update CHANGELOG.md

* Update CHANGELOG.md [skip ci]

Co-authored-by: Hsiao-nan Cheung &lt;niheaven@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 ### Bug Fixes
 
 - **config:** Change config option to snake_case in file and SCREAMING_CASE in code ([#5116](https://github.com/ScoopInstaller/Scoop/issues/5116))
+- **psmodule:** Remove folder recursively when unlinking previous module path ([#5127](https://github.com/ScoopInstaller/Scoop/issues/5127))
 
 ### Code Refactoring
 
diff --git a/lib/psmodules.ps1 b/lib/psmodules.ps1
@@ -23,7 +23,7 @@ function install_psmodule($manifest, $dir, $global) {
 
     if (Test-Path $linkfrom) {
         warn "$(friendly_path $linkfrom) already exists. It will be replaced."
-        Remove-Item -Path $linkfrom -Force -ErrorAction SilentlyContinue
+        Remove-Item -Path $linkfrom -Force -Recurse -ErrorAction SilentlyContinue
     }
 
     New-DirectoryJunction $linkfrom $dir | Out-Null
@@ -40,7 +40,7 @@ function uninstall_psmodule($manifest, $dir, $global) {
     if (Test-Path $linkfrom) {
         Write-Host "Removing $(friendly_path $linkfrom)"
         $linkfrom = Convert-Path $linkfrom
-        Remove-Item -Path $linkfrom -Force -ErrorAction SilentlyContinue
+        Remove-Item -Path $linkfrom -Force -Recurse -ErrorAction SilentlyContinue
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ function install_psmodule($manifest, $dir, $global) {`
`23`	`23`
`24`	`24`	`if (Test-Path $linkfrom) {`
`25`	`25`	`warn "$(friendly_path $linkfrom) already exists. It will be replaced."`
`26`		`- Remove-Item -Path $linkfrom -Force -ErrorAction SilentlyContinue`
	`26`	`+ Remove-Item -Path $linkfrom -Force -Recurse -ErrorAction SilentlyContinue`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`New-DirectoryJunction $linkfrom $dir \| Out-Null`
`@@ -40,7 +40,7 @@ function uninstall_psmodule($manifest, $dir, $global) {`
`40`	`40`	`if (Test-Path $linkfrom) {`
`41`	`41`	`Write-Host "Removing $(friendly_path $linkfrom)"`
`42`	`42`	`$linkfrom = Convert-Path $linkfrom`
`43`		`- Remove-Item -Path $linkfrom -Force -ErrorAction SilentlyContinue`
	`43`	`+ Remove-Item -Path $linkfrom -Force -Recurse -ErrorAction SilentlyContinue`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`