Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked if uninstaller removed its directory. #2078

Merged

Conversation

excitoon
Copy link
Contributor

@excitoon excitoon commented Mar 2, 2018

Sometimes uninstaller removes its own directory by itself. In these cases scoop fails uninstallation process with the following error:

PS C:\Users\Chebotarev_V\scoop\apps\scoop\current> scoop uninstall flux
Uninstalling 'flux' (4.66).
Running uninstaller... done.
Removing shim for 'flux'.
Unlinking ~\scoop\apps\flux\current
ERROR Couldn't remove '~\scoop\apps\flux\4.66'; it may be in use.

Example:

scoop bucket add user https://github.com/excitoon/scoop-user.git
scoop install user/flux

This patch fixes it.

@r15ch13 r15ch13 merged commit 4d956c2 into ScoopInstaller:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants