Fix "enable-encryptionscheme" for OSes before Windows 10 #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
milang
commented
Mar 4, 2018
milang
commented
- Fixes iex cannot convert Tls12 to type System.Int32 #2083
- Tested on Windows 8.1 and Windows 10
- Also fixes indentation + clarifying comment
- Tested on Windows 8.1 and Windows 10 - Also fixes indentation + clarifying comment
chawyehsu
reviewed
Mar 4, 2018
lib/core.ps1
Outdated
| [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor $scheme | ||
| # Net.SecurityProtocolType is a [Flags] enum, binary-OR sets | ||
| # the specified scheme in addition to whatever scheme is already active | ||
| [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor ([Net.SecurityProtocolType]$scheme) |
There was a problem hiding this comment.
[Net.SecurityProtocolType]$scheme will become [Net.SecurityProtocolType]"Tls12", does it work? Why not [Net.SecurityProtocolType]::Tls12
There was a problem hiding this comment.
Because it is a function that accepts $scheme. The function can be called with other parameters in the future.
... does it work?
Yes I tested in Windows 8.1 and 10.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.